Vitor-Avila commented on code in PR #32344:
URL: https://github.com/apache/superset/pull/32344#discussion_r1968062986
##########
superset/jinja_context.py:
##########
@@ -602,7 +601,10 @@ def process_template(self, sql: str, **kwargs: Any) -> str:
kwargs.update(self._context)
context = validate_template_context(self.engine, kwargs)
- return template.render(context)
+ try:
+ return template.render(context)
+ except RecursionError as ex:
+ raise SupersetTemplateException("Cyclic filters detected") from ex
Review Comment:
nit: Should we say "Cyclic Jinja macros detected"? Thinking that if the
cyclic flow is caused by a `{{ metric() }}` macro, `filters` might be
confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
