betodealmeida commented on code in PR #32048: URL: https://github.com/apache/superset/pull/32048#discussion_r1970671295
########## superset/commands/database/validate.py: ########## @@ -96,7 +96,7 @@ def run(self) -> None: server_cert=self._properties.get("server_cert", ""), extra=self._properties.get("extra", "{}"), impersonate_user=self._properties.get("impersonate_user", False), - encrypted_extra=serialized_encrypted_extra, + encrypted_extra=json.dumps(encrypted_extra), Review Comment: ```python encrypted_extra = json.loads(serialized_encrypted_extra) ``` Dumping again instead of using `serialized_encrypted_extra` because it might have changed in the call to `engine_spec.build_sqlalchemy_uri`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org