mistercrunch commented on issue #32426: URL: https://github.com/apache/superset/issues/32426#issuecomment-2692936100
Seems reasonable - very possible that the people who set it up or altered it didn't know the intricacies around docker/docker-compose networking. Feel free to open a PR improving it. One thing that's sub-ideal is the fact that `docker-compose-image-tag.yml` and `docker-compose-non-dev.yml` are served on 8088, which is inconsistent with docker-compose being on `9000` now. The idea with both of these is to fire up an environment from a pre-built image (as opposed to building from the local checked out repo/branch/ref) to get things running and play with them. We may want to move these use cases to minikube/helm, or collapse the 2 files into one. Note that @villebro is also planning on exposing a k8s operator to Superset in a different repo, and that acts as an alternative to the helm chart we have today, and would be there to support production use cases. In any case, we could certainly improve the docs and assets around all this, and clarify the level and mechanisms of support behind each of these. P ersonally I'm super committed to getting the main `docker-compose.yml` for devex [developer experience], making it as easy as possible for contributors/committers to have a super solid way to spin up a dev environment on any given github ref, with all the bells and whistles (celery backend, redis for caching, postgres as a solid backend, ....). The use case for `docker-compose-image-tag.yml` is "being able to spin up any official baked release to take it on a quick test. drive". That's super important too and can be conflated with the devex use case. Here we don't need all the bells and whistles, and to rebuild everything as systematically as we do to support devex. Docs could be more explicit and aligned with the person's intent which loosely fall under the 3 use cases: - I want to set up and environment to do active development and contribute - I want to take Superset for a quick test drive on my local machine or a sandbox of some kind - I want to set up a production environment for my organization (k8s, metal, helm-preferred VS k8s operator preferred, ...) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
