korbit-ai[bot] commented on code in PR #32529:
URL: https://github.com/apache/superset/pull/32529#discussion_r1983704521
##########
superset/utils/slack.py:
##########
@@ -54,60 +56,82 @@ def get_slack_client() -> WebClient:
return client
+@cache_util.memoized_func(
+ key="slack_conversations_list",
+ cache=cache_manager.cache,
+)
+def get_channels(limit: int, extra_params: dict[str, Any]) ->
list[SlackChannelSchema]:
Review Comment:
Thanks for your response, Vitor-Avila. If the cache_timeout parameter is
being set where `get_channels` is called, you can disregard my previous comment
about hardcoding it in the decorator. However, it's essential to make sure the
cache is being appropriately invalidated or refreshed to avoid serving
redundant information. If possible, could you please share the relevant code
section for a more comprehensive review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
