Antonio-RiveroMartnez commented on code in PR #32538:
URL: https://github.com/apache/superset/pull/32538#discussion_r1985260291
##########
superset/migrations/versions/2024-05-10_18-02_f84fde59123a_update_charts_with_old_time_comparison.py:
##########
@@ -85,7 +85,7 @@ def upgrade_comparison_params(slice_params: dict[str, Any])
-> dict[str, Any]:
# Adjust adhoc_custom
if "adhoc_custom" in params and params["adhoc_custom"]:
adhoc = params["adhoc_custom"][0] # As there's always only one element
- if adhoc["comparator"] != "No filter":
Review Comment:
it would enter this conditional and `start_date_offset.strftime("%Y-%m-%d")`
would fail since `get_since_until(adhoc["comparator"])` would return `None` as
the `start_date`. So the PR is preventing the `AttributeError: 'NoneType'` in
case it's `None`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
