kasiazjc commented on PR #32112: URL: https://github.com/apache/superset/pull/32112#issuecomment-2706728460
Thank yo so much @EnxDev ❤️ A few things I found so far - Action icons in CRUD views are 24x24px and should be 16x16px for a more balanced look (for example favorites star is 16x16) <img width="1293" alt="image" src="https://github.com/user-attachments/assets/985f6da1-ce01-4f2b-a350-a28d8bfaa18f"; /> - Icons in buttons should be bigger (10px is not really visible), I can see in ant-d they are 14x14px and we can follow that for keeping our implementation pretty much vanilla without lots of deviations. I can see that on master we use in here some weird size like 10x12, but the previous icon was much more bold, so it needs to be bigger. NOTE: I found that in some buttons we use 16px (for example save button in explore), so not sure what the rule is. Is this the correct time to update it? @EnxDev @geido <img width="373" alt="image" src="https://github.com/user-attachments/assets/84a96c95-8fb1-4628-8d57-0ca9c8a57d54"; /> - might be old implementation, but this icon should match other button icons like mentioned above (14px) <img width="335" alt="image" src="https://github.com/user-attachments/assets/15aaac66-3428-4975-b396-b039a7359f9d"; /> - For somer reasons in the navbar spacings between caret-down and text/icons disappeared. Can you add at least 4px spacings? now: <img width="949" alt="image" src="https://github.com/user-attachments/assets/5800be7a-281c-4c73-b88a-2a205f7d818c"; /> before: <img width="949" alt="image" src="https://github.com/user-attachments/assets/9a58d041-6e0c-416b-af95-2ce7f301bb1e"; /> - Controls in control panel - in the new implementation the caret-right is filled, and should be just an empty arrow like currently now: <img width="302" alt="image" src="https://github.com/user-attachments/assets/ccb0b01f-d5e8-4b51-b394-32fc9e728c80"; /> before: <img width="302" alt="image" src="https://github.com/user-attachments/assets/93d1c7d9-06b7-45be-94a6-adc253014af9"; /> - in dashboard filters panel (vertical) sizing between gear and collapse icon got bigger than before. It should be 8px now: <img width="258" alt="image" src="https://github.com/user-attachments/assets/46a6ac5b-411f-427c-b791-2b33a91af1e6"; /> before: <img width="258" alt="image" src="https://github.com/user-attachments/assets/d8166a20-efec-4c68-81c0-88a7e811f80b"; /> - Icon in dataset settings should be 16px for better balance <img width="972" alt="image" src="https://github.com/user-attachments/assets/d9a6484b-4615-46da-a15d-aa7ab7802354"; /> - not sure if this icon should be new too, but pencil doesnt seem to be updated to our current edit icon (like above) <img width="972" alt="image" src="https://github.com/user-attachments/assets/e03b3236-0e43-465a-9d74-2e11bb41f2cc"; /> - this caret (collapse/expand) icon on the right should match icons on the left (arrow not filled) <img width="725" alt="image" src="https://github.com/user-attachments/assets/2cc67b78-1250-40e1-b3c2-35bdc3cc08ca"; /> <img width="972" alt="image" src="https://github.com/user-attachments/assets/3cd964db-11e8-47ff-b506-98791b0eb66d"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
