mistercrunch commented on code in PR #32485:
URL: https://github.com/apache/superset/pull/32485#discussion_r1985675646
##########
superset/db_engine_specs/drill.py:
##########
@@ -99,31 +102,27 @@ def get_schema_from_engine_params(
return parse.unquote(sqlalchemy_uri.database).replace("/", ".")
@classmethod
- def get_url_for_impersonation(
+ def impersonate_user(
cls,
- url: URL,
- impersonate_user: bool,
+ database: Database,
username: str | None,
- access_token: str | None,
- ) -> URL:
- """
- Return a modified URL with the username set.
-
- :param url: SQLAlchemy URL object
- :param impersonate_user: Flag indicating if impersonation is enabled
- :param username: Effective username
- """
- if impersonate_user and username is not None:
- if url.drivername == "drill+odbc":
- url = url.update_query_dict({"DelegationUID": username})
- elif url.drivername in ["drill+sadrill", "drill+jdbc"]:
- url = url.update_query_dict({"impersonation_target": username})
- else:
- raise SupersetDBAPIProgrammingError(
- f"impersonation is not supported for {url.drivername}"
- )
-
- return url
+ user_token: str | None,
+ url: URL,
+ engine_kwargs: dict[str, Any],
+ ) -> tuple[URL, dict[str, Any]]:
Review Comment:
a docstring here would be good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
