korbit-ai[bot] commented on code in PR #32640:
URL: https://github.com/apache/superset/pull/32640#discussion_r1992422808
##########
superset/db_engine_specs/presto.py:
##########
@@ -1257,26 +1259,31 @@ def get_extra_table_metadata(
) -> dict[str, Any]:
metadata = {}
- if indexes := database.get_indexes(table):
- col_names, latest_parts = cls.latest_partition(
- database,
- table,
- show_first=True,
- indexes=indexes,
- )
-
- if not latest_parts:
- latest_parts = tuple([None] * len(col_names))
-
- metadata["partitions"] = {
- "cols": sorted(indexes[0].get("column_names", [])),
- "latest": dict(zip(col_names, latest_parts, strict=False)),
- "partitionQuery": cls._partition_query(
- table=table,
+ try:
+ if indexes := database.get_indexes(table):
+ col_names, latest_parts = cls.latest_partition(
+ database,
+ table,
+ show_first=True,
indexes=indexes,
- database=database,
- ),
- }
+ )
+
+ if not latest_parts:
+ latest_parts = tuple([None] * len(col_names))
+
+ metadata["partitions"] = {
+ "cols": sorted(indexes[0].get("column_names", [])),
+ "latest": dict(zip(col_names, latest_parts, strict=False)),
+ "partitionQuery": cls._partition_query(
+ table=table,
+ indexes=indexes,
+ database=database,
+ ),
+ }
+ except NoSuchTableError as ex:
+ raise SupersetDBAPIProgrammingError(
+ "Table doesn't seem to exist on the database"
+ ) from ex
Review Comment:
### Missing Table Name in Error Message <sub></sub>
<details>
<summary>Tell me more</summary>
###### What is the issue?
The error message doesn't include the table name or schema which makes it
harder for users to identify which table is missing.
###### Why this matters
Without the table name in the error message, users have to spend more time
debugging and identifying which table caused the error.
###### Suggested change ∙ *Feature Preview*
Include table details in the error message for better error reporting:
```python
raise SupersetDBAPIProgrammingError(
f"Table '{table.schema}.{table.table}' doesn't exist in the
database"
) from ex
```
</details>
<sub>
[](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/b3888376-605e-4eb4-96a3-7a7ed7dd4ce4?suggestedFixEnabled=true)
💬 Looking for more details? Reply to this comment to chat with Korbit.
</sub>
<!--- korbi internal id:b7deabd3-ce38-4286-a9be-5b7eed2120f7 -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
