villebro opened a new pull request, #32641: URL: https://github.com/apache/superset/pull/32641
### SUMMARY The signature on the `create_index` migration util doesn't align with that of the signature of the corresponding classmethod in [alembic](https://github.com/sqlalchemy/alembic/blob/f4b269a370264eae531277fe795e1f9bee2a0446/alembic/operations/ops.py#L929-L941): - no `unique` option - the columns need to be an explicit list, as otherwise we can't have an optional `unique` in it. By adding an optional `unique` flag and making `columns` an explicit list rather than variable arguments makes it possible to create unique indexes, and more closely aligns with the original class method in alembic. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
