betodealmeida commented on code in PR #32546:
URL: https://github.com/apache/superset/pull/32546#discussion_r1993559661
##########
superset/databases/api.py:
##########
@@ -1433,51 +1433,15 @@ def oauth2(self) -> FlaskResponse:
$ref: '#/components/responses/500'
"""
parameters = OAuth2ProviderResponseSchema().load(request.args)
+ command = OAuth2StoreTokenCommand(parameters)
+ command.run()
- if "error" in parameters:
- raise OAuth2Error(parameters["error"])
-
- # note that when decoding the state we will perform JWT validation,
preventing a
- # malicious payload that would insert a bogus database token, or
delete an
- # existing one.
state = decode_oauth2_state(parameters["state"])
+ tab_id = state["tab_id"]
Review Comment:
Yeah, I agree this is not ideal. But I made the command return the created
model instance, and unfortunately it doesn't have `tab_id` associated with it.
I thought it was better to keep the interface simple, and have a bit of
duplicity here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
