john-bodley commented on issue #7330: Add dotenv to dependencies URL: https://github.com/apache/incubator-superset/pull/7330#issuecomment-493216266 @mistercrunch apologies for the delay in responding. I recently upgraded some other Flask apps to Flask 1.0 and was exposed to the newer way of configuring/running applications. I agree that including the dependency for `python-dotenv` makes sense however I was wondering whether this should be included in `requirements-dev.txt` rather than `requirements.txt` as i) one actually doesn't require this to run Superset, and ii) I was wondering whether there was a concern that in production any CLI calls, i.e., `superset db upgrade` would be run using the `FLASK_ENV='development'` environment per [here](https://github.com/pallets/flask/blob/1dda032b00cb4f7a783e018a7c370ee88f15e797/flask/cli.py#L34) which reads the `.flaskenv` if the `dotenv` package is present. Also in your PR in the [CONTRIBUTING.md](https://github.com/apache/incubator-superset/blob/master/CONTRIBUTING.md#flask-server) by including this package, I believe ``` cd superset FLASK_ENV=development flask run -p 8088 --with-threads --reload --debugger ``` now simplifies to, ``` flask run -p 8088 --with-threads ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
