eschutho commented on code in PR #32663:
URL: https://github.com/apache/superset/pull/32663#discussion_r1994458085
##########
tests/unit_tests/charts/test_client_processing.py:
##########
@@ -2060,6 +2060,97 @@ def test_apply_client_processing_csv_format():
}
+def test_apply_client_processing_csv_format_simple_table():
+ """
+ It should be able to process csv results
+ And not show a default column
+ """
+
+ result = {
+ "queries": [
+ {
+ "result_format": ChartDataResultFormat.CSV,
+ "data": """
+COUNT(is_software_dev)
+4725
+""",
+ }
+ ]
+ }
+ form_data = {
+ "datasource": "19__table",
+ "viz_type": "table",
+ "slice_id": 69,
+ "url_params": {},
+ "granularity_sqla": "time_start",
+ "time_grain_sqla": "P1D",
+ "time_range": "No filter",
+ "groupbyColumns": [],
+ "groupbyRows": [],
+ "metrics": [
+ {
+ "aggregate": "COUNT",
+ "column": {
+ "column_name": "is_software_dev",
+ "description": None,
+ "expression": None,
+ "filterable": True,
+ "groupby": True,
+ "id": 1463,
+ "is_dttm": False,
+ "python_date_format": None,
+ "type": "DOUBLE PRECISION",
+ "verbose_name": None,
+ },
+ "expressionType": "SIMPLE",
+ "hasCustomLabel": False,
+ "isNew": False,
+ "label": "COUNT(is_software_dev)",
+ "optionName": "metric_9i1kctig9yr_sizo6ihd2o",
+ "sqlExpression": None,
+ }
+ ],
+ "metricsLayout": "COLUMNS",
+ "adhoc_filters": [
+ {
+ "clause": "WHERE",
+ "comparator": "Currently A Developer",
+ "expressionType": "SIMPLE",
+ "filterOptionName": "filter_fvi0jg9aii_2lekqrhy7qk",
+ "isExtra": False,
+ "isNew": False,
+ "operator": "==",
+ "sqlExpression": None,
+ "subject": "developer_type",
+ }
+ ],
+ "row_limit": 10000,
+ "order_desc": True,
+ "aggregateFunction": "Sum",
+ "valueFormat": "SMART_NUMBER",
+ "date_format": "smart_date",
+ "rowOrder": "key_a_to_z",
+ "colOrder": "key_a_to_z",
+ "extra_form_data": {},
+ "force": False,
+ "result_format": "json",
+ "result_type": "results",
+ }
+
+ assert apply_client_processing(result, form_data) == {
+ "queries": [
+ {
+ "result_format": ChartDataResultFormat.CSV,
+ "data": "COUNT(is_software_dev)\n4725\n",
Review Comment:
no default column here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
