mistercrunch commented on code in PR #32571:
URL: https://github.com/apache/superset/pull/32571#discussion_r1996303410
##########
superset-frontend/.eslintrc.js:
##########
@@ -292,6 +386,7 @@ module.exports = {
],
rules: {
'theme-colors/no-literal-colors': 'error',
+ 'icons/no-fa-icons-usage': 'warn',
Review Comment:
Personally would much rather have a proper `error`, combinated with `# NOQA`
type statements for all of the entries we need to fix. Stops the bleeding in
its track, and it's pretty easy to `grep` for the related NOQA statements.
##########
superset-frontend/.eslintrc.js:
##########
@@ -292,6 +386,7 @@ module.exports = {
],
rules: {
'theme-colors/no-literal-colors': 'error',
+ 'icons/no-fa-icons-usage': 'warn',
Review Comment:
Personally would much rather have a proper `error`, combined with `# NOQA`
type statements for all of the entries we need to fix. Stops the bleeding in
its track, and it's pretty easy to `grep` for the related NOQA statements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
