korbit-ai[bot] commented on code in PR #32670:
URL: https://github.com/apache/superset/pull/32670#discussion_r1996435791
##########
superset/importexport/api.py:
##########
@@ -177,6 +177,7 @@ def import_(self) -> Response:
if not contents:
raise NoValidFilesFoundError()
+ sparse = request.form.get("sparse") == "true"
Review Comment:
Thank you for pointing that out. However, maintaining consistency with how
it was being done across other import APIs was a conscious choice while
implementing this. Your suggestion can be a future enhancement to improve the
robustness. Also we could take this up as a separate refactor task across the
parts of codebase where we are making similar parsing. Sounds good?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
