pivconbrt commented on issue #30704: URL: https://github.com/apache/superset/issues/30704#issuecomment-2728151600
@dkrat7 / @dosu - Thank you for logging this issue and a tip on what are of the source code may need changes. As a heavy user of the handlebar chart, I can confirm this problem exists in v4.1.1 and it is not in the release notes of v4.1.2 as being fixed. You can loose a lot of work in a complicated handlebars template when you update a datasource. We have been making sure every handlebar template is stored in source control outside of superset so we can recover them as we trip over this issue across the team frequently. It's easy to remember it once it happens, but if you have 8 people in superset and person B edits person A's chart they can easily blow out the template if they are not aware of the bug/issue. @dosu, I see you footnoted a reference to the source code that has the code with the useMemo hook. We may attempt to resovle the issue in the code as we have forked the code to add some custom charts and are getting more familiar with the code. Do you have any tips/comments on what should be done to save the template so it's not lost? We could try that and test it and put in a merge request if we fix it. We are open to any recommendations on next steps (e.g. is there another example of code/etc. that would be helpful to review to understand best practices/patterns in superset code base related to maintaining the chart configuration state across data changes. I understand that if the model/schema changes it can break a normal chart/etc. In this case, with it being a handlebar template I think we can just let it stay as is and it just won't work if the reference dimension is not available after the datasource change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
