Antonio-RiveroMartnez commented on code in PR #32735:
URL: https://github.com/apache/superset/pull/32735#discussion_r2002433782
##########
superset-embedded-sdk/src/index.ts:
##########
@@ -64,6 +64,8 @@ export type EmbedDashboardParams = {
iframeTitle?: string
/** additional iframe sandbox attributes ex (allow-top-navigation,
allow-popups-to-escape-sandbox) **/
iframeSandboxExtras?: string[]
+ /** force a specific refererPolicy to be used in the iframe request **/
+ referrerPolicy?: ReferrerPolicy | null
Review Comment:
nit: if already optional and null is only used as "is set?" you should be
fine w/o it like all others optionals here. You wouldn't need the default =
null neither.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
