michael-s-molina commented on code in PR #32759:
URL: https://github.com/apache/superset/pull/32759#discussion_r2004013774
##########
superset/migrations/shared/utils.py:
##########
@@ -406,3 +406,33 @@ def drop_index(table_name: str, index_name: str) -> None:
)
op.drop_index(table_name=table_name, index_name=index_name)
+
+
+def drop_fks_for_table_by_names(table_name: str, constraint_names: list[str])
-> None:
Review Comment:
I think it would be better in terms of simplicity and to reduce lines of
code to modify the original `drop_fks_for_table` to accept an optional list of
foreign key names. You can make it clear in the docstring that if a list is not
supplied, all foreign keys will be deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
