mistercrunch commented on code in PR #32770:
URL: https://github.com/apache/superset/pull/32770#discussion_r2005896388


##########
superset/utils/core.py:
##########
@@ -1292,6 +1292,19 @@ def get_user_email() -> str | None:
         return None
 
 
+def get_user_roles() -> list[str] | None:

Review Comment:
   Not sure why we need this method in `core.py`. (?) Seems you could simply 
use this `[role.name for role in g.user.roles]` in `superset/jinja_context.py`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to