125m125 opened a new pull request, #32891:
URL: https://github.com/apache/superset/pull/32891

   <!---
   Please write the PR title following the conventions at 
https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   * Adds Ubuntu 24.04 and the need for an older python version to the pypi 
installation instructions.
   * Adds note that the statsd-package needs to be installed for the 
StatsdStatsLogger and how to inspect errors
     * Suggestion: Maybe instead of suppressing the exception, superset could 
still create the `StatsdStatsLogger` class but it throws the caught exception 
on init so the users can see the actual problem?
   ```
   try:
       from statsd import StatsClient
       ...
   except Exception as e:  # pylint: disable=broad-except
       class StatsdStatsLogger(BaseStatsLogger):
           def __init__(  # pylint: disable=super-init-not-called
               self,
               host: str = "localhost",
               port: int = 8125,
               prefix: str = "superset",
               statsd_client: Optional[StatsClient] = None,
           ) -> None:
               raise e
   ```
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to