pomegranited commented on code in PR #31692:
URL: https://github.com/apache/superset/pull/31692#discussion_r2017809008
##########
superset/initialization/__init__.py:
##########
@@ -701,3 +703,34 @@ class SupersetIndexView(IndexView):
@expose("/")
def index(self) -> FlaskResponse:
return redirect("/superset/welcome/")
+
+ @staticmethod
+ def is_safe_url(target: str) -> bool:
Review Comment:
Thank you @mistercrunch ! I didn't find a similar method anywhere, so
[4bb4916](https://github.com/apache/superset/pull/31692/commits/4bb49161c04f4cedeaeba30d9fabf9889fd9497c)
creates `superset.utils.urls.is_safe_redirect_url(source_url, target_url)`.
Does this look ok now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
