mistercrunch commented on PR #32857: URL: https://github.com/apache/superset/pull/32857#issuecomment-2762940865
> @mistercrunch looking at what types of label mutations we have in place, they're pretty varied: some suffix a partial MD5, some lowercase everything, some replace periods with underscores, some ensure the first character isn't a number etc. So a one size fits all solution likely won't work well. But I agree that this is probably ripe for refactoring, as it's pretty unintuitive to expect specs to implement a private method for something like this.. 😬 Any downside on systematically applying suffixes? Also wondering if it could break backwards compatibility... Didn't seem so but didn't dig into it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
