EnxDev commented on code in PR #32705:
URL: https://github.com/apache/superset/pull/32705#discussion_r2021423978
##########
superset-frontend/src/components/Skeleton/index.tsx:
##########
@@ -16,6 +16,6 @@
* specific language governing permissions and limitations
* under the License.
*/
+import { Skeleton } from 'antd-v5';
-export { default as TagsList } from './TagsList';
-export { default as Tag } from './Tag';
+export default Skeleton;
Review Comment:
@geido and I were discussing modifying them in all components in a separate
PR. @geido , what do you suggest we do?
Should I change the export types from default to named for all components in
this PR, or should we open a separate one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
