EnxDev commented on code in PR #32729:
URL: https://github.com/apache/superset/pull/32729#discussion_r2021833207
##########
superset-frontend/src/features/databases/DatabaseModal/SSHTunnelForm.tsx:
##########
@@ -18,7 +18,7 @@
*/
import { useState } from 'react';
import { t, styled } from '@superset-ui/core';
-import { AntdForm, Col, Row } from 'src/components';
+import { Col, Row } from 'src/components';
Review Comment:
follow this https://github.com/apache/superset/pull/32729/files#r2008119444
##########
superset-frontend/src/dashboard/components/PropertiesModal/index.tsx:
##########
@@ -19,10 +19,10 @@
import { useCallback, useEffect, useMemo, useRef, useState } from 'react';
import { omit } from 'lodash';
import { Input } from 'src/components/Input';
-import { FormItem } from 'src/components/Form';
+import { Form, FormItem } from 'src/components/Form';
import jsonStringify from 'json-stringify-pretty-compact';
import Button from 'src/components/Button';
-import { AntdForm, AsyncSelect, Col, Row } from 'src/components';
+import { AsyncSelect, Col, Row } from 'src/components';
Review Comment:
follow this https://github.com/apache/superset/pull/32729/files#r2008119444
##########
superset-frontend/src/features/databases/DatabaseModal/DatabaseConnectionForm/EncryptedField.tsx:
##########
@@ -19,7 +19,7 @@
import { useRef, useState } from 'react';
import { SupersetTheme, t } from '@superset-ui/core';
import { Button, AntdSelect } from 'src/components';
Review Comment:
follow this https://github.com/apache/superset/pull/32729/files#r2008119444
##########
superset-frontend/src/filters/components/TimeColumn/TimeColumnFilterPlugin.tsx:
##########
@@ -25,9 +25,8 @@ import {
} from '@superset-ui/core';
import { useEffect, useState } from 'react';
import { Select } from 'src/components';
Review Comment:
follow this https://github.com/apache/superset/pull/32729/files#r2008119444
##########
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Vertical.tsx:
##########
@@ -103,6 +103,9 @@ const FilterBarEmptyStateContainer = styled.div`
`;
const FilterControlsWrapper = styled.div`
+ display: flex;
+ flex-direction: column;
+ gap: ${({ theme }) => theme.sizeUnit * 2}px;
padding: ${({ theme }) => theme.sizeUnit * 4}px;
Review Comment:
We should use tagged template literals?
##########
superset-frontend/src/features/databases/UploadDataModel/index.tsx:
##########
@@ -35,20 +35,14 @@ import Modal from 'src/components/Modal';
import Button from 'src/components/Button';
import { Switch, SwitchProps } from 'src/components/Switch';
import Collapse from 'src/components/Collapse';
-import {
- AntdForm,
- AsyncSelect,
- Col,
- Row,
- Select,
- Upload,
-} from 'src/components';
+import { AsyncSelect, Col, Row, Select, Upload } from 'src/components';
Review Comment:
follow this https://github.com/apache/superset/pull/32729/files#r2008119444
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
