castodius opened a new pull request, #32958: URL: https://github.com/apache/superset/pull/32958
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY This change adds a Dashboard advanced setting allowing the expansion of all chart descriptions. The setting respects individual chart descriptions - if one is set to not expand upon Dashboard load then it won't. A description shown upon load via this setting can be hidden using **Hide chart description** and the expanded again using **Show chart description**. At the time of creation this PR does not include new integration tests. If the intended functionality looks good I will be happy to add tests. I have edited the minimal number of files I think makes sense, but it is a large project which makes it harder to navigate. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before:  *Video Games Sales Dashboard with no descriptions shown upon load* After:  *Enabling the setting*  *All chart descriptions shown*  *Disabling showing of description for chart 70*  *Description for chart 70 does not get shown by default* ### TESTING INSTRUCTIONS Basic test - Add descriptions to two charts that are part of the same Dashboard - Edit advanced settings for the Dashboard, setting "expand_all_slices" to be true - Load the Dashboard, the chart descriptions should be shown - Edit advanced settings to disable expansion of one the dashboards - Load the Dashboard. Only one chart description should be shown by default Extensive testing - Iterate over the nine options of undefined, true and false for chart times expand all - Ensure default expansion is handled as expected in the table below  ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: https://github.com/apache/superset/discussions/32916 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [x] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
