Vitor-Avila commented on code in PR #29422:
URL: https://github.com/apache/superset/pull/29422#discussion_r2026882892
##########
superset-frontend/src/dashboard/components/DashboardBuilder/state.ts:
##########
@@ -29,6 +29,9 @@ import {
// eslint-disable-next-line import/prefer-default-export
export const useNativeFilters = () => {
const [isInitialized, setIsInitialized] = useState(false);
+ const showNativeFilters = useSelector<RootState, boolean>(
+ state => getUrlParam(URL_PARAMS.showFilters) ?? true,
Review Comment:
@michael-s-molina my understanding is that the original PR fully removed
`metadata.show_native_filters` (from all places). I suspect the reason for it
is that this metadata config was intended to permanently hide the native
filters on dashboards that had filter box, until it was fully migrated. So I
don't think we need that back. If we want to bring that logic, we would need to
re-update the schemas, and logic in other places too.
Not sure if you had a chance to test in that ephemeral but I believe things
are working properly with these changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
