alexandrusoare commented on code in PR #32810:
URL: https://github.com/apache/superset/pull/32810#discussion_r2028450305
##########
superset-frontend/src/components/Datasource/DatasourceModal.tsx:
##########
@@ -68,6 +68,10 @@ const StyledDatasourceModal = styled(Modal)`
.modal-footer {
flex: 0 1 auto;
}
+
+ .antd5-tabs-top {
+ margin-top: -${({ theme }) => theme.sizeUnit * 4}px;
Review Comment:
With:
<img width="863" alt="image"
src="https://github.com/user-attachments/assets/f26a2faa-b49f-424d-b73b-d6758a27e9ec";
/>
Without:
<img width="878" alt="image"
src="https://github.com/user-attachments/assets/1e5141f8-f052-4d02-87c8-5b24aa1db041";
/>
Let me know if it looks ok without. This line was previously in the
`src/components/Modal`, and there was a comment which said to place it in the
Datasource modal as it is the only modal that needs this styling. My personal
opinion is that it looks better with rather than without
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
