DamianPendrak commented on code in PR #32959:
URL: https://github.com/apache/superset/pull/32959#discussion_r2026645433
##########
superset-frontend/src/SqlLab/components/TableElement/index.tsx:
##########
@@ -273,77 +242,96 @@ const TableElement = ({ table, ...props }:
TableElementProps) => {
);
}
return (
- <ButtonGroup
- css={css`
- column-gap: ${theme.sizeUnit * 1.5}px;
- margin-right: ${theme.sizeUnit}px;
- & span {
- display: flex;
- justify-content: center;
- width: ${theme.sizeUnit * 4}px;
- }
- `}
- >
- <IconTooltip
- className="pull-left m-l-2 pointer"
- onClick={refreshTableMetadata}
- tooltip={t('Refresh table schema')}
- >
- <Icons.SyncOutlined
- iconSize="m"
- iconColor={theme.colors.primary.dark2}
- />
- </IconTooltip>
- {keyLink}
- <IconTooltip
- className={
- `fa fa-sort-${sortColumns ? 'numeric' : 'alpha'}-asc ` +
- 'pull-left sort-cols m-l-2 pointer'
- }
- onClick={toggleSortColumns}
- tooltip={
- sortColumns
- ? t('Original table column order')
- : t('Sort columns alphabetically')
- }
- />
- {tableData.selectStar && (
- <CopyToClipboard
- copyNode={
+ <StyledControls>
+ {isMetadataFetching || isExtraMetadataLoading ? (
+ <Loading position="inline" />
+ ) : (
+ <Fade
+ data-test="fade"
+ hovered={hovered}
+ onClick={e => e.stopPropagation()}
+ >
+ <ButtonGroup
+ css={css`
+ column-gap: ${theme.sizeUnit * 1.5}px;
+ margin-right: ${theme.sizeUnit}px;
+
+ & span {
+ display: flex;
+ justify-content: center;
+ width: ${theme.sizeUnit * 4}px;
+ }
+ `}
+ >
+ <IconTooltip
+ className="pull-left m-l-2 pointer"
+ onClick={refreshTableMetadata}
+ tooltip={t('Refresh table schema')}
+ >
+ <Icons.SyncOutlined
+ iconSize="m"
+ iconColor={theme.colors.grayscale.dark5}
Review Comment:
Okay, I thought that the contrast is too low with the theme.colorIcon. I
will update the code, but let me know if something changes because of the
contrast
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
