mistercrunch commented on code in PR #32850:
URL: https://github.com/apache/superset/pull/32850#discussion_r2013018845
##########
superset-frontend/plugins/plugin-chart-echarts/package.json:
##########
@@ -24,10 +24,10 @@
"lib"
],
"dependencies": {
+ "@types/react-redux": "^7.1.10",
"d3-array": "^1.2.0",
- "lodash": "^4.17.21",
"dayjs": "^1.11.13",
- "@types/react-redux": "^7.1.10"
+ "lodash": "^4.17.21"
Review Comment:
oh wait, I thought it was added, but you simply re-ordered them. Now
wondering whether it should have been a peerDep in the first place (?)
##########
superset-frontend/plugins/plugin-chart-echarts/package.json:
##########
@@ -24,10 +24,10 @@
"lib"
],
"dependencies": {
+ "@types/react-redux": "^7.1.10",
"d3-array": "^1.2.0",
- "lodash": "^4.17.21",
"dayjs": "^1.11.13",
- "@types/react-redux": "^7.1.10"
+ "lodash": "^4.17.21"
Review Comment:
oh wait, I thought it was new dep you added, but you simply re-ordered
them. Now wondering whether it should have been a peerDep in the first place (?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
