msyavuz commented on code in PR #32964:
URL: https://github.com/apache/superset/pull/32964#discussion_r2030955016
##########
superset-frontend/src/components/TableCollection/index.tsx:
##########
@@ -32,299 +33,131 @@ interface TableCollectionProps {
loading: boolean;
highlightRowId?: number;
columnsForWrapText?: string[];
+ setSortBy?: (updater: SortingRule<any>[]) => void;
+ bulkSelectEnabled?: boolean;
+ selectedFlatRows?: any[];
Review Comment:
I checked this and the only improvement i can make here is that we can use
`Row<any>` in `selectedFlatRows`. I made the change but these are types from
react-table's useTable hook.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
