rusackas commented on PR #32707: URL: https://github.com/apache/superset/pull/32707#issuecomment-2783960884
Spinning up an ephemeral environment so we can all play around with this and figure out if it's the behavior we want. I see from the video that adding a Stack dimension automatically checks the Stack checkbox (awesome), but I what I might _expect_ is something like: * Stack dimension input is not shown until the checkbox is checked * When you check the box and _don't_ pick a dimension, it acts like it does today (no change in behavior) * When you select a Stack By dimension, the new logic is applied. I'm a little confused by the actual logic here like @sadpandajoe is, but I'll play with it on the ephemeral and see if I can make heads or tails of it. Also, for what it's worth, someone was just asking me about this exact feature, so I'm very excited about this getting merged once we all agree on the details :D -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
