msyavuz commented on code in PR #32980:
URL: https://github.com/apache/superset/pull/32980#discussion_r2033253383
##########
superset-frontend/src/components/Checkbox/Checkbox.tsx:
##########
@@ -16,43 +16,12 @@
* specific language governing permissions and limitations
* under the License.
*/
-import { CSSProperties } from 'react';
-import { styled } from '@superset-ui/core';
-import { CheckboxChecked, CheckboxUnchecked } from 'src/components/Checkbox';
+import { Checkbox as AntCheckbox } from 'antd-v5';
+import type {
+ CheckboxProps as AntCheckboxProps,
+ CheckboxChangeEvent as AntCheckboxChangeEvent,
+} from 'antd-v5/lib/checkbox';
Review Comment:
For future reference if we can import from "antd-v5/es" instead we should do
that.
[Here](https://github.com/ant-design/ant-design/discussions/42660#discussioncomment-6012700)'s
the reference (for treeshaking).
```suggestion
} from 'antd-v5/es/checkbox';
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
