Re: [PR] fix: use Input & TextArea instead of native and [superset]</span></a></span> </h1> <p class="darkgray font13"> <span class="sender pipe"><a href="/search?l=notifications@superset.apache.org&q=from:%22via+GitHub%22" rel="nofollow"><span itemprop="author" itemscope itemtype="http://schema.org/Person"><span itemprop="name">via GitHub</span></span></a></span> <span class="date"><a href="/search?l=notifications@superset.apache.org&q=date:20250408" rel="nofollow">Tue, 08 Apr 2025 11:13:47 -0700</a></span> </p> </div> <div itemprop="articleBody" class="msgBody"> <!--X-Body-of-Message--> <pre> geido commented on code in PR #32989: URL: <a rel="nofollow" href="https://github.com/apache/superset/pull/32989#discussion_r2033759400">https://github.com/apache/superset/pull/32989#discussion_r2033759400</a></pre><pre> ########## superset-frontend/src/components/Chart/DrillDetail/DrillDetailMenuItems.test.tsx: ########## @@ -396,7 +396,7 @@ test('context menu for supported chart, dimensions, filter B', async () => { await expectDrillToDetailByDimension(filterB); }); -test('context menu for supported chart, dimensions, all filters', async () => { +test.skip('context menu for supported chart, dimensions, all filters', async () => { Review Comment: I think I have fixed this in some other PR. I can unskip it later. ########## superset-frontend/src/explore/components/DatasourcePanel/index.tsx: ########## @@ -276,18 +277,20 @@ export default function DataSourcePanel({ datasource.type && saveableDatasets[datasource.type as keyof typeof saveableDatasets]; + const theme = useTheme(); const mainBody = useMemo( () => ( <> - <Input - allowClear - onChange={evt => { - setInputValue(evt.target.value); - }} - value={inputValue} - className="form-control input-md" - placeholder={t('Search Metrics & Columns')} - /> + <div style={{ padding: theme.sizeUnit * 4 }}> Review Comment: Should we use a `Space` or `Flex` component for this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org </pre> </div> <div class="msgButtons margintopdouble"> <ul class="overflow"> <li class="msgButtonItems"><a class="button buttonleft " accesskey="p" href="msg210954.html">Previous message</a></li> <li class="msgButtonItems textaligncenter"><a class="button" accesskey="c" href="thrd13.html#210955">View by thread</a></li> <li class="msgButtonItems textaligncenter"><a class="button" accesskey="i" href="mail11.html#210955">View by date</a></li> <li class="msgButtonItems textalignright"><a class="button buttonright " accesskey="n" href="msg210961.html">Next message</a></li> </ul> </div> <a name="tslice"></a> <div class="tSliceList margintopdouble"> <ul class="icons monospace"> <li class="icons-email"><span class="subject"><a href="msg210496.html">[PR] fix: use Input & TextArea instead of native <input&...</a></span> <span class="sender italic">via GitHub</span></li> <li><ul> <li class="icons-email"><span class="subject"><a href="msg210172.html">Re: [PR] fix: use Input & TextArea instead of native &...</a></span> <span class="sender italic">via GitHub</span></li> <li class="icons-email"><span class="subject"><a href="msg210544.html">Re: [PR] fix: use Input & TextArea instead of native &...</a></span> <span class="sender italic">via GitHub</span></li> <li class="icons-email"><span class="subject"><a href="msg210953.html">Re: [PR] fix: use Input & TextArea instead of native &...</a></span> <span class="sender italic">via GitHub</span></li> <li class="icons-email"><span class="subject"><a href="msg210954.html">Re: [PR] fix: use Input & TextArea instead of native &...</a></span> <span class="sender italic">via GitHub</span></li> <li class="icons-email tSliceCur"><span class="subject">Re: [PR] fix: use Input & TextArea instead of native &...</span> <span class="sender italic">via GitHub</span></li> <li class="icons-email"><span class="subject"><a href="msg210961.html">Re: [PR] fix: use Input & TextArea instead of native &...</a></span> <span class="sender italic">via GitHub</span></li> <li class="icons-email"><span class="subject"><a href="msg210963.html">Re: [PR] fix: use Input & TextArea instead of native &...</a></span> <span class="sender italic">via GitHub</span></li> </ul> </ul> </div> <div class="overflow msgActions margintopdouble"> <div class="msgReply" > <h2> Reply via email to </h2> <form method="POST" action="/mailto.php"> <input type="hidden" name="subject" value="Re: [PR] fix: use Input & TextArea instead of native <input> and <textarea> [superset]"> <input type="hidden" name="msgid" value="PR_kwDOAlosUs6RIxAe-17ac1606-1a9e-4cab-a1b3-5f7f1913cf77@gitbox.apache.org"> <input type="hidden" name="relpath" value="notifications@superset.apache.org/msg210955.html"> <input type="submit" value=" via GitHub "> </form> </div> </div> </div> <div class="aside" role="complementary"> <div class="logo"> <a href="/"><img src="/logo.png" width=247 height=88 alt="The Mail Archive"></a> </div> <form class="overflow" action="/search" method="get"> <input type="hidden" name="l" value="notifications@superset.apache.org"> <label class="hidden" for="q">Search the site</label> <input class="submittext" type="text" id="q" name="q" placeholder="Search notifications"> <input class="submitbutton" name="submit" type="image" src="/submit.png" alt="Submit"> </form> <div class="nav margintop" id="nav" role="navigation"> <ul class="icons font16"> <li class="icons-home"><a href="/">The Mail Archive home</a></li> <li class="icons-list"><a href="/notifications@superset.apache.org/">notifications - all messages</a></li> <li class="icons-about"><a href="/notifications@superset.apache.org/info.html">notifications - about the list</a></li> <li class="icons-expand"><a href="/search?l=notifications@superset.apache.org&q=subject:%22Re%5C%3A+%5C%5BPR%5C%5D+fix%5C%3A+use+Input+%5C%26+TextArea+instead+of+native+%3Cinput%3E+and+%3Ctextarea%3E+%5C%5Bsuperset%5C%5D%22&o=newest&f=1" title="e" id="e">Expand</a></li> <li class="icons-prev"><a href="msg210954.html" title="p">Previous message</a></li> <li class="icons-next"><a href="msg210961.html" title="n">Next message</a></li> </ul> </div> <div class="listlogo margintopdouble"> </div> <div class="margintopdouble"> </div> </div> </div> <div class="footer" role="contentinfo"> <ul> <li><a href="/">The Mail Archive home</a></li> <li><a href="/faq.html#newlist">Add your mailing list</a></li> <li><a href="/faq.html">FAQ</a></li> <li><a href="/faq.html#support">Support</a></li> <li><a href="/faq.html#privacy">Privacy</a></li> <li class="darkgray">PR_kwDOAlosUs6RIxAe-17ac1606-1a9e-4cab-a1b3-5f7f1913cf77@gitbox.apache.org</li> </ul> </div> </body> </html> <script>(function(){function c(){var b=a.contentDocument||a.contentWindow.document;if(b){var d=b.createElement('script');d.innerHTML="window.__CF$cv$params={r:'9df5612b1ce7227c',t:'MTc3NDAxNjY1Nw=='};var a=document.createElement('script');a.src='/cdn-cgi/challenge-platform/scripts/jsd/main.js';document.getElementsByTagName('head')[0].appendChild(a);";b.getElementsByTagName('head')[0].appendChild(d)}}if(document.body){var a=document.createElement('iframe');a.height=1;a.width=1;a.style.position='absolute';a.style.top=0;a.style.left=0;a.style.border='none';a.style.visibility='hidden';document.body.appendChild(a);if('loading'!==document.readyState)c();else if(window.addEventListener)document.addEventListener('DOMContentLoaded',c);else{var e=document.onreadystatechange||function(){};document.onreadystatechange=function(b){e(b);'loading'!==document.readyState&&(document.onreadystatechange=e,c())}}}})();</script>