Re: [PR] feat: add bulk update owner functionality to charts and dashboards [superset]

Tue, 08 Apr 2025 13:00:38 -0700 


JZ6 commented on PR #33040:
URL: https://github.com/apache/superset/pull/33040#issuecomment-2787527775

   > Thank you for the PR and discussion @vedantprajapati.
   > 
   > Bulk editing is a highly requested feature at Airbnb and I completely 
understand its value. I do think though that we should think about it 
holistically as multiple attributes of an asset can be bulk edited. I don't 
think adding specific actions for each attribute is sustainable given the 
number of attributes an asset can have. For example, these are some of the 
attributes that can be bulk edited:
   > 
   > * Owners (Editors and Viewers later)
   > * Certified
   > * Color scheme
   > * Cache timeout
   > * Theme
   > * etc
   > 
   > We also need to think how things will work when the values differ between 
selected assets. For example, let's say that we have the following:
   > 
   > Dashboard 1
   > 
   > * Owners: A, B, C
   > 
   > Dashboard 2
   > 
   > * Owners: B, D, F
   > 
   > Dashboard 3
   > 
   > * Owners: F, X, Y
   > 
   > How would bulk editing work? In the following screenshot, what would be 
the initial value of the Owners select? Do you start with an empty select and 
only allow adding new owners? Do you override everything for all dashboards? 
What if you need to just add/remove one owner?
   > 
   > <img alt="Screenshot 2025-04-08 at 16 45 30" width="598" 
src="https://private-user-images.githubusercontent.com/70410625/431544847-714bed9a-4416-4ec9-baec-4cf506c2bc94.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDQxNDIxMzYsIm5iZiI6MTc0NDE0MTgzNiwicGF0aCI6Ii83MDQxMDYyNS80MzE1NDQ4NDctNzE0YmVkOWEtNDQxNi00ZWM5LWJhZWMtNGNmNTA2YzJiYzk0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDA4VDE5NTAzNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWFmMTYwNTFjOGJjM2RhYjQ4OTE4NmFjM2QzNjEwOTE2MWYxYWFiNTA4Y2M4ZmJiZmFiZTcyZjE0NTU1NDY1OTMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.JucpJLhye8QvC1L280P8IGXA-lykldlQDnH3SXxBJsQ";>
   
   definitely should not add an action per attribute, this is how we do it:
   
![image](https://github.com/user-attachments/assets/946b2195-e5e8-4904-91a4-fd6d424093ac)
   
   Each field like owner color cache timeout can just be a new field in the 
bulk update modal.
   
   As for the behaviour it is expected that any edited fields will be applied 
to all selected charts, and if a field is not modified, it should not be bulk 
updated.
   
   As for `What if you need to just add/remove one owner` perhaps we need an 
overwrite/append toggle ha
   
   How does this sound?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to