betodealmeida commented on code in PR #33048:
URL: https://github.com/apache/superset/pull/33048#discussion_r2035270360
##########
superset/sql_parse.py:
##########
@@ -272,7 +272,7 @@ def _extract_tables_from_sql(self) -> set[Table]:
logger.warning("Unable to parse SQL (%s): %s", self._dialect,
self.sql)
raise SupersetSecurityException(
SupersetError(
- error_type=SupersetErrorType.QUERY_SECURITY_ACCESS_ERROR,
+ error_type=SupersetErrorType.INVALID_SQL_ERROR,
Review Comment:
Thanks! The intent here was that we often need to extract tables in order to
see if a query can run, but obviously we do for other reasons. Potentially we
could add a try/except in the security manager to capture this error and
convert it to a security error, but I don't think it's necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
