landryb commented on PR #32432:
URL: https://github.com/apache/superset/pull/32432#issuecomment-2789646953
fwiw, i've found a small regression from this PR, some of the requests done
are invalid URLs according to RFCs, and when superset is behind a java proxy,
those trigger 400 codes.
i've locally fixed them this way:
```
--- i/superset-frontend/src/pages/RolesList/index.tsx
+++ w/superset-frontend/src/pages/RolesList/index.tsx
@@ -114,7 +114,7 @@ function RolesList({ addDangerToast, addSuccessToast,
user }: RolesListProps) {
const fetchPage = async (pageIndex: number) => {
const response = await SupersetClient.get({
- endpoint:
`api/v1/security/permissions-resources/?q={"page_size":${pageSize},
"page":${pageIndex}}`,
+ endpoint:
`api/v1/security/permissions-resources/?q=(page_size:${pageSize},page:${pageIndex})`,
});
return {
@@ -163,7 +163,7 @@ function RolesList({ addDangerToast, addSuccessToast,
user }: RolesListProps) {
const fetchPage = async (pageIndex: number) => {
const response = await SupersetClient.get({
- endpoint:
`api/v1/security/users/?q={"page_size":${pageSize},"page":${pageIndex}}`,
+ endpoint:
`api/v1/security/users/?q=(page_size:${pageSize},page:${pageIndex})`,
});
return response.json;
};
```
can do a PR with that if that is deemed reasonable/acceptable.
with this fixed, the new roles page works fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
