rusackas commented on PR #32995: URL: https://github.com/apache/superset/pull/32995#issuecomment-2790592817
Not to confuse this issue further, but @geido brought up a good point that perhaps the dimming/disabling shouldn't be the business of the Icon component, but perhaps the link it's wrapped in? In this case it's a <span> with and onClick handler, but maybe we _should be_ using a (modified?) `IconButton` component for these. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
