sadpandajoe commented on code in PR #33070: URL: https://github.com/apache/superset/pull/33070#discussion_r2036273165
########## superset/migrations/versions/2016-07-25_17-48_ad82a75afd82_add_query_model.py: ########## @@ -22,16 +22,18 @@ """ +import sqlalchemy as sa +from alembic import op Review Comment: I see we have an add columns, which we should move over to `add_columns`: https://github.com/apache/superset/blob/5537c6fcd12ad6d4e932832245441a69178bd39b/superset/migrations/shared/utils.py#L305C5-L305C16 There is also a `create_index`: https://github.com/apache/superset/blob/5537c6fcd12ad6d4e932832245441a69178bd39b/superset/migrations/shared/utils.py#L365 And a `drop_columns`: https://github.com/apache/superset/blob/5537c6fcd12ad6d4e932832245441a69178bd39b/superset/migrations/shared/utils.py#L335 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
