Re: [PR] refactor(Collapse): Upgrade Collapse to Antd5 [superset]

Thu, 10 Apr 2025 14:22:23 -0700 


DamianPendrak commented on PR #32959:
URL: https://github.com/apache/superset/pull/32959#issuecomment-2784480594

   > * The color of the subtitle seems hard to see. Is this a vanilla Ant 
Design implementation?
   >   ![Screenshot 2025-04-07 at 17 13 
09](https://private-user-images.githubusercontent.com/60598000/430975949-638f1695-df42-49cd-be26-9a24b4755fe1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDQwNTU2NDksIm5iZiI6MTc0NDA1NTM0OSwicGF0aCI6Ii82MDU5ODAwMC80MzA5NzU5NDktNjM4ZjE2OTUtZGY0Mi00OWNkLWJlMjYtOWEyNGI0NzU1ZmUxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDA3VDE5NDkwOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTg1MjYwNGUzZmYzMmM0NTI3NmRlNjE3NTkxMjRmNmI5NmY4MjMxZjhiMWEzY2NlM2E3MmFkMWRhNWY1MDBkOTMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.mvfnTQ_zu0XSg1LJjcJNMPrjiEGgGaOXJ4hGhZM6T9I)
   > * When I first visited the homepage I found all collapse closed. I don't 
believe I closed them. Something to check.
   >   ![Screenshot 2025-04-07 at 17 11 
50](https://private-user-images.githubusercontent.com/60598000/430975961-03c53c87-8111-49c2-9f8e-2f8b9146587f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDQwNTU2NDksIm5iZiI6MTc0NDA1NTM0OSwicGF0aCI6Ii82MDU5ODAwMC80MzA5NzU5NjEtMDNjNTNjODctODExMS00OWMyLTlmOGUtMmY4YjkxNDY1ODdmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDA3VDE5NDkwOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWVkZDY3ZmFmMDExYjAyY2EwNDIyNWZhZmRjMzcwMjBjZWY5M2MzOGI2NmQ4YTczOWZjZWVjOGFmOGQ1NmNkOTAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0._2XInB3w9JUlOt2A01Y02Ixt9NpZC09eKGpMfLEhWSs)
   > * Colors of text inside the collapse for filters is off. Is it because of 
Checkbox? Currently being developed 
[here](https://github.com/apache/superset/pull/32980)
   >   ![Screenshot 2025-04-07 at 17 11 
22](https://private-user-images.githubusercontent.com/60598000/430975966-be9c7da5-c276-4726-a341-cc57f0aa7906.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDQwNTU2NDksIm5iZiI6MTc0NDA1NTM0OSwicGF0aCI6Ii82MDU5ODAwMC80MzA5NzU5NjYtYmU5YzdkYTUtYzI3Ni00NzI2LWEzNDEtY2M1N2YwYWE3OTA2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDA3VDE5NDkwOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWE5MmFjMTNlNDJhNTU4NjFiM2Y3MDM4YTMxM2YyYTAyMjRlNzY5NGJiNTg0NjMxYTk0YTBmNzZmYzE1NmU3YzQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.AstX1PTLi9n4NLsin7O3gWF8LB7CjWUiYMUKF43TAu4)
   > 
   > You have a conflict. Thanks for the hard work on this!
   
   Fixed except for the Checkbox text color. This is the default Checkbox from 
Ant Design without custom styles.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to