sadpandajoe commented on code in PR #33007:
URL: https://github.com/apache/superset/pull/33007#discussion_r2031684782
##########
superset-frontend/src/dashboard/actions/dashboardState.js:
##########
@@ -98,23 +98,25 @@ export function toggleFaveStar(isStarred) {
return { type: TOGGLE_FAVE_STAR, isStarred };
}
-export function fetchFaveStar(id) {
- return function fetchFaveStarThunk(dispatch) {
+export function fetchFavoriteStatus(dashboardId) {
+ return dispatch => {
return SupersetClient.get({
- endpoint: `/api/v1/dashboard/favorite_status/?q=${rison.encode([id])}`,
+ endpoint: `/api/v1/dashboard/${dashboardId}/favorite_status`,
Review Comment:
How come the url changed from `/dashboard/favorite_status` to
`/dashboard/*/favorite_status`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
