geido commented on code in PR #33081:
URL: https://github.com/apache/superset/pull/33081#discussion_r2039285541


##########
superset-frontend/src/components/EmptyState/index.tsx:
##########
@@ -36,7 +35,9 @@ import EmptySqlChartImage from 
'src/assets/images/empty_sql_chart.svg';
 import EmptyQueryImage from 'src/assets/images/empty-query.svg';
 import EmptyTableImage from 'src/assets/images/empty-table.svg';
 import EmptyImage from 'src/assets/images/empty.svg';
+import { Button } from '../Button';

Review Comment:
   There have been some issues with circular dependencies caused by pulling 
components from the barrel file within components inside components and I 
figured we should just use relative imports. We might revisit this when we move 
to a dedicated package and split things a bit better. This has grown too large 
already. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to