UncoveredBread opened a new pull request, #33111: URL: https://github.com/apache/superset/pull/33111
Fixes #32776 Removed the non-functional `subheader_font_size` control from Big Number with Trendline in `plugin-chart-echarts/src/BigNumber/sharedControls.ts`, as it had no effect on the subheader. Updated related tests in `superset-ui-core/test/time-comparison/` by removing `subheader_font_size` references. Verification - Manually tested: Confirmed the "Subheader Font Size" dropdown is gone from the "Customize" tab of a Big Number with Trendline chart, and the chart renders correctly (e.g., displays the number and trendline). - Note: I couldn’t run `npm run test` due to an `ENOENT: no such file or directory` error when running from the root directory. I believe the tests should pass after removing `subheader_font_size` references, but I’d appreciate assistance in running them correctly or confirmation via CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
