msyavuz commented on code in PR #33038:
URL: https://github.com/apache/superset/pull/33038#discussion_r2041639071
##########
superset-frontend/src/features/databases/DatabaseModal/index.tsx:
##########
@@ -1882,137 +1880,166 @@ const DatabaseModal:
FunctionComponent<DatabaseModalProps> = ({
/>
</TabHeader>
</StyledStickyHeader>
- <TabsStyled
+ <Tabs
defaultActiveKey={DEFAULT_TAB_KEY}
activeKey={tabKey}
onTabClick={tabChange}
animated={{ inkBar: true, tabPane: true }}
- >
- <Tabs.TabPane tab={<span>{t('Basic')}</span>} key="1">
- {useSqlAlchemyForm ? (
- <StyledAlignment>
- <SqlAlchemyForm
- db={db as DatabaseObject}
- onInputChange={({ target }: { target: HTMLInputElement }) =>
- onChange(ActionType.InputChange, {
- type: target.type,
- name: target.name,
- checked: target.checked,
- value: target.value,
- })
- }
- conf={conf}
- testConnection={testConnection}
- testInProgress={testInProgress}
- >
- <SSHTunnelSwitchComponent
- dbModel={dbModel}
+ items={[
Review Comment:
Just a heads up this will have merge conflicts with
https://github.com/apache/superset/pull/33057
##########
superset-frontend/src/features/alerts/components/ValidatedPanelHeader.tsx:
##########
@@ -38,18 +39,29 @@ const ValidatedPanelHeader = ({
/>
);
return (
- <div className="collapse-panel-header">
- <div className="collapse-panel-title" data-test={testId}>
- <span>{t(title)}</span>
+ <div>
+ <Space size="small" data-test={testId}>
+ <h5
+ style={{
+ fontSize: theme.fontSizeLG,
+ }}
+ >
+ {t(title)}
+ </h5>
Review Comment:
I think this is a good opportunity to use our Typography component.
Something like `<Title level={5}>`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
