vuongtlt13 opened a new pull request, #29557: URL: https://github.com/apache/superset/pull/29557
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> <h2>Improve speed of ParsedQuery for checking is_read_only_query too slow</h2> Line: [superset/db_engine_specs/base.py](https://github.com/vuongtlt13/superset/blob/feature/improve_parsed_query/superset/db_engine_specs/base.py#L2027)  ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable -->  First, I have a sql statement with length is 17121. I need check **is_read_only_query** As you can see: - **For current ParsedQuery class**: Each function in **is_select**, **is_explain**, **is_show** will format sql statement by calling **sqlparse.format** function. But it takes quite long (~**0.332s** for one call). So you need to call **3 times** for checking **is_read_only_query** --> Total time: **0.9996**s - **For new ParsedQuery class**: You need to call only **1 time** for checking **is_read_only_query** --> Total time: **0.3278**s <h4> ---> Reduce 66% in total time for checking is_read_only_query </4> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
