msyavuz commented on code in PR #33043:
URL: https://github.com/apache/superset/pull/33043#discussion_r2044631804
##########
superset-frontend/src/components/Select/Select.tsx:
##########
@@ -308,37 +310,32 @@ const Select = forwardRef(
const handleOnDeselect: SelectProps['onDeselect'] = (value, option) => {
if (Array.isArray(selectValue)) {
- if (getValue(value) === getValue(SELECT_ALL_VALUE)) {
- clear();
- } else {
- let array = selectValue as AntdLabeledValue[];
- array = array.filter(
- element => getValue(element) !== getValue(value),
+ let array = selectValue as AntdLabeledValue[];
+ array = array.filter(element => getValue(element) !== getValue(value));
Review Comment:
Fixed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
