justinpark opened a new pull request, #33138:
URL: https://github.com/apache/superset/pull/33138

   ### SUMMARY
   This commit modifies the incorrect tooltip data transformation format 
function to use the same format function applied in the existing nvd3, ensuring 
that the tooltip date display is consistently transformed according to the time 
grain.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   |Time Grain|NVD3|Before|After|
   |--|--|--|--|
   
|Month|![Notification_Center](https://github.com/user-attachments/assets/72c55330-1d36-4834-af8f-020644a963dc)|![Notification_Center](https://github.com/user-attachments/assets/31de0fac-8515-4312-9924-85027bc28105)|![Notification_Center](https://github.com/user-attachments/assets/0f9d8960-3256-4893-886b-f2a0b9895701)|
   
|Week|![Notification_Center](https://github.com/user-attachments/assets/56ff71ec-de34-43e4-8329-d777868f2218)|![Notification_Center](https://github.com/user-attachments/assets/2fe89978-a90c-40ef-9b3c-4bafda8a921b)|![Notification_Center](https://github.com/user-attachments/assets/ef70cd5f-fbbf-42fa-800b-717215a4c6d7)|
   
|Hour|![Notification_Center](https://github.com/user-attachments/assets/6d880b82-4f7a-4776-a2d7-995c14c130df)|![Notification_Center](https://github.com/user-attachments/assets/434aa568-60d9-4a2b-bc9f-5e4b6c2da7cf)|![Notification_Center](https://github.com/user-attachments/assets/fee2d9a2-edcf-4f05-91c2-e4b2c6c0b76f)|
   
   ### TESTING INSTRUCTIONS
   Select a line chart and choose a time column as x-axis 
   Select different time grain and see the tooltip's description
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to