vanaigr opened a new pull request, #33140:
URL: https://github.com/apache/superset/pull/33140

   ### SUMMARY
   
   Changed the order in which metrics and columns are displayed in the dataset 
panel on `/explore` page. 
   
   Before, columns were sorted by whether they are certified and whether they 
are datetime. Metrics were sorted by certification (but only when searching?). 
   
   Now, both columns and metrics are sorted by certification, then 
alphabetically, case and accent insensitively. This doesn't apply to folders, 
since I assume the feature is in progress.
   
   Rationale:
   Some users don't find the current order natural, especially in tables with 
many columns. I checked and it seems that the order of columns (before sorting 
for display) is different from that in the source table. So from their point of 
view, the order is essentially random.
   
   I assume there should be a setting or a config flag that changes the order 
to the old one, since there are benefits in showing datetime columns first?
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Left image is before, right is after:
   
   
![image](https://github.com/user-attachments/assets/3e273517-447f-4a5a-8790-6075631bd752)
 
![image](https://github.com/user-attachments/assets/b14b8318-ea4d-4d61-a790-bf0a5973a062)
   
   ### TESTING INSTRUCTIONS
   
   Open a chart, e.g. "wb_health_population" "Box plot" from the example data.
   
   Metrics should be displayed in alphabetical order, and columns should be in 
alphabetical order, but all certified metrics and columns should be displayed 
before uncertified.
   
   Uppercase letters should not matter. 
   Display name should be used, which may be different from column/metric name.
   When searching, results should be sorted the same way.
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to