Antonio-RiveroMartnez commented on code in PR #33099:
URL: https://github.com/apache/superset/pull/33099#discussion_r2046459915
##########
superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberPeriodOverPeriod/transformProps.ts:
##########
@@ -26,7 +26,12 @@ import {
SimpleAdhocFilter,
ensureIsArray,
} from '@superset-ui/core';
-import { getComparisonFontSize, getHeaderFontSize } from './utils';
+import {
+ getComparisonFontSize,
+ getHeaderFontSize,
+ getMetricNameFontSize,
+} from './utils';
+import { getFriendlyMetricName } from '../utils';
Review Comment:
The `friendlyName` is not called like that in the table chart, could we be
consistent? https://github.com/apache/superset/pull/32665 also, not sure but,
is this something we can extract and reuse both in table and BN?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
