geido commented on code in PR #33090:
URL: https://github.com/apache/superset/pull/33090#discussion_r2046731946
##########
superset-frontend/src/components/Divider/index.tsx:
##########
@@ -16,12 +16,18 @@
* specific language governing permissions and limitations
* under the License.
*/
-
+import { css } from '@superset-ui/core';
import { Divider as AntdDivider } from 'antd-v5';
import type { DividerProps } from './types';
export function Divider(props: DividerProps) {
- return <AntdDivider {...props} />;
+ return (
+ <AntdDivider
+ css={theme => css`
+ margin: ${theme.sizeUnit * 4}px 0;
Review Comment:
Can we use the Ant Design `theme.margin` value for this? Looking at the Ant
Design theme editor it is `16px` so you can use that instead of `sizeUnit`.
##########
superset-frontend/src/components/IconTooltip/index.tsx:
##########
@@ -16,9 +16,31 @@
* specific language governing permissions and limitations
* under the License.
*/
-import { Tooltip } from '../Tooltip';
+import { ReactNode } from 'react';
+import { Tooltip, Button } from 'src/components';
import type { IconTooltipProps } from './types';
+export interface Props {
Review Comment:
What is this here for?
##########
superset-frontend/src/components/DynamicEditableTitle/index.tsx:
##########
@@ -16,20 +16,19 @@
* specific language governing permissions and limitations
* under the License.
*/
-
import {
ChangeEvent,
KeyboardEvent,
memo,
useCallback,
useEffect,
useLayoutEffect,
- useRef,
useState,
} from 'react';
-import { css, SupersetTheme, t } from '@superset-ui/core';
+import { css, SupersetTheme, t, useTheme } from '@superset-ui/core';
+import { Tooltip } from 'src/components/Tooltip';
import { useResizeDetector } from 'react-resize-detector';
-import { Tooltip } from '../Tooltip';
+import { Input } from 'src/components/Input';
Review Comment:
Keep relative imports. I won't comment on others but let's make sure we
rollback these changes
##########
superset-frontend/src/components/Datasource/DatasourceEditor.jsx:
##########
@@ -32,6 +32,23 @@ import {
withTheme,
getClientErrorObject,
} from '@superset-ui/core';
+import {
Review Comment:
Going from `src/components` within the components themselves can cause
circular dependency issues. Please keep relative imports inside components.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
