mistercrunch opened a new pull request, #33153: URL: https://github.com/apache/superset/pull/33153
Was reading recently about how modern tree-shaking 💨🌳🍂 works in modern web apps, and the `sideEffect` property in `package.json` was mentionned so I checked to see our settings. Apparently we don't have it set right - unless I'm missing something - so I decided to open a DRAFT PR to test things and have the conversation. Apparently the `sideEffect` we have in `webpack.config.js` is probably an artifact/legacy from a previous era. Nowadays npm packages should define weather/which sideEffect they contain as a hint for the bundler to tree-shake the right things. Anyhow, let's see if this builds and passes CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
