justinpark opened a new pull request, #33164:
URL: https://github.com/apache/superset/pull/33164

   ### SUMMARY
   The InvalidSQLError message introduced in #30501 had an issue where, in 
certain 
[cases](https://github.com/apache/superset/blob/master/superset/sql/parse.py#L342),
 if the extra payload was not included, it would cause a page error instead of 
displaying the error message.
   This commit fixes the issue by ensuring the error message is displayed 
without errors in such cases.
   Additionally, this commit fixed the existing INVALID_SQL_ERROR block where 
the extra payload was missing.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Before:
   
   
https://github.com/user-attachments/assets/02731178-fca7-4785-989c-c3560e55c768
   
   After:
   
   
https://github.com/user-attachments/assets/81ee6e51-31d0-4662-aebf-ebb4e056b7a4
   
   
   ### TESTING INSTRUCTIONS
   specs
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to